wait until after delete step to check that linodeCluster still exists #95
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljohnson92
requested review from
mhmxs,
avestuk,
luthermonson and
AshleyDumaine
eljohnson92
force-pushed
the
fix_cluster_delete
branch
2 times, most recently
from
07002ce to
56c69d5
Compare
eljohnson92
force-pushed
the
fix_cluster_delete
branch
2 times, most recently
from
dc4dfd0 to
10f0008
Compare
AshleyDumaine
approved these changes
Feb 8, 2024
avestuk
reviewed
Feb 9, 2024
eljohnson92
force-pushed
the
fix_cluster_delete
branch
from
10f0008 to
d542401
Compare
…. tag resources by cluster label instead of UUID
eljohnson92
force-pushed
the
fix_cluster_delete
branch
from
d542401 to
7fa7b9f
Compare
avestuk
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where checking for a cluster existing happens while stuff is in the process of deleting and some resources don't get deleted. just move the check until after we validate if we are doing a delete operation. this also changes the tagging in cloud manager to be based on cluster
nameinstead ofuuidfor easier readability.